Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actualize demo #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Actualize demo #9

wants to merge 1 commit into from

Conversation

Zhaars
Copy link

@Zhaars Zhaars commented Sep 6, 2023

Actualize the demo by removing the usage of old self-managed docker image and use official ones instead.

@Zhaars Zhaars requested review from vixentael and Lagovas September 6, 2023 14:55
Copy link

@Lagovas Lagovas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't run it, so I hope it still works and prevents sql injections)

# Open the port outside for client application
image: mutillidae
build:
context: https://github.com/webpwnized/mutillidae-docker.git#1.0.39:www
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, didn't know that it can work with web resources

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for www

ports:
- "8080:80"
- "3306:3306"
context: https://github.com/webpwnized/mutillidae-docker.git#1.0.39:database
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really need this context? looks like it's empty folder with only dockerfile

Copy link
Contributor

@vixentael vixentael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for changing the illustration scheme!!

@Lagovas
Copy link

Lagovas commented Sep 7, 2023

only one problem that we will have old video with connector on schemas ))

@Zhaars
Copy link
Author

Zhaars commented Sep 7, 2023

only one problem is that we will have an old video with the connector on schemas ))

@vixentael Should we create a new video?)

@vixentael
Copy link
Contributor

maybe let's delete the video or mark it as deprecated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants